add logout #8
add logout #8
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR implements logout functionality by adding a logout handler to the authentication buttons component and configures Next.js to allow remote images from icons8.com.
- Added logout functionality with proper error handling in the AuthButtons component
- Updated Next.js configuration to support remote image patterns for icons8.com
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| next.config.ts | Added remote image pattern configuration for icons8.com |
| components/NavbarComponents/AuthButtons.tsx | Implemented handleLogout function and connected it to the logout button |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| const handleLogout = async () => { | ||
| const { error } = await supabase.auth.signOut(); | ||
| if (!error) setUser(null); | ||
| else throw error; | ||
| }; |
There was a problem hiding this comment.
The error handling pattern is inconsistent. Either handle the error gracefully (e.g., show a user-friendly message) or let it bubble up, but throwing an error after a user action without proper error boundaries could result in a poor user experience.
| const nextConfig: NextConfig = { | ||
| /* config options here */ | ||
| images: { | ||
| remotePatterns: [new URL("https://img.icons8.com/**")], |
There was a problem hiding this comment.
The remotePatterns configuration is incorrect. It should be an array of objects with hostname and pathname properties, not URL instances. This should be: remotePatterns: [{ protocol: 'https', hostname: 'img.icons8.com', pathname: '/**' }]
| remotePatterns: [new URL("https://img.icons8.com/**")], | |
| remotePatterns: [{ protocol: 'https', hostname: 'img.icons8.com', pathname: '/**' }], |
add logout