no login in development fix? #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an authentication redirect issue in development by replacing server-side environment variable with client-side origin detection for OAuth callback URLs.
- Replaces
process.env.SITE_URLwithwindow.location.originfor OAuth redirect URL construction
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| provider, | ||
| options: { | ||
| redirectTo: `${process.env.SITE_URL}/auth/callback`, | ||
| redirectTo: `${window.location.origin}/auth/callback`, |
There was a problem hiding this comment.
Using window.location.origin for redirect URLs can be a security risk as it allows potential redirect attacks. Consider validating the origin against a whitelist of allowed domains or using a server-side environment variable with proper fallback logic for development.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.