Remove deprecated refit_denovo_signatures parameter from sigprofiler_extract#475
Draft
Remove deprecated refit_denovo_signatures parameter from sigprofiler_extract#475
Conversation
…extract Co-authored-by: ShixiangWang <25057508+ShixiangWang@users.noreply.github.com>
… decomposition Co-authored-by: ShixiangWang <25057508+ShixiangWang@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix refit error in sigprofiler_extract
Remove deprecated refit_denovo_signatures parameter from sigprofiler_extract
Dec 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
refit_denovo_signaturesparameter was removed in newer versions of SigProfilerExtractor, causingunused argumenterrors when users callsigprofiler_extract().Changes
refit_denovo_signaturesfrom both the directsigpro$sigProfilerExtractor()call and the fallback command stringrefitparameter as deprecated with clear deprecation noticerefitin function signature to avoid breaking existing code (parameter is now silently ignored)Example
Users can now call the function without encountering parameter errors:
The function will work with both older SigProfilerExtractor versions (that ignore missing parameters) and newer versions (that reject the deprecated parameter).
Additional
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.