Skip to content

Added Security Measures #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
githubofakash wants to merge 5 commits into
base: master
Choose a base branch
from
+17 −6
Open

Added Security Measures #68

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d4671a1
add otp and env libraries
githubofakash Nov 11, 2022
93059bd
Merge pull request #1 from githubofakash/githubofakash-patch-1
githubofakash Nov 11, 2022
1340dd4
add environment variables to securely store data
githubofakash Nov 11, 2022
d73b2ca
add automated otp generation
githubofakash Nov 11, 2022
619bd6a
correct variable assignment
githubofakash Nov 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@
#credentials
uid = os.getenv('userid')
pwd = os.getenv('password')
factor2 = os.getenv('totp')
vc = otp
vc = os.getenv('vendor_code')
app_key = os.getenv('api_key')
imei = <imei>
factor2 = otp
Copy link
Copy Markdown

@TheCodeArtist TheCodeArtist Nov 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of pushing commits with issues and separate commits to fix them,
please consider rebasing your changes into logical commits.


#make the api call
ret = api.login(userid=uid, password=pwd, twoFA=factor2, vendor_code=vc, api_secret=app_key, imei=imei)
Expand Down