Skip to content

Conversation

@kiftio
Copy link
Contributor

@kiftio kiftio commented Aug 20, 2025

What changes are you making?

Adds a new module/package checkout-sheet-kit-compose.

A wrapper around the core checkout sheet kit lib, including the compose dependencies and a component. A bit like https://github.com/google-pay/compose-pay-button

Leaves existing users unaffected (no additional dependencies/depdendency conflicts, etc), and allows opting into the compose version.

ShopifyCheckout(
        url = checkoutUrl,
        isVisible = showCheckout,
        onComplete = { checkoutCompletedEvent ->
            showCheckout = false
        },
        onCancel = {
            showCheckout = false
        },
        ...
}

There's some reworking of the build to avoid lots of duplication.

Notes

  • We need to consider sequencing with the rename. But pushing it up for some feedback.
  • I've called it CheckoutView, to make it less specific to sheets, and work for inline use-cases in the future
  • I've matched up naming where possible with the Swift UI version (onPixelEvent, onFail, onCancel etc)
    • We've also talked about removing onPixelEvent for more top-level events.

How to test

The Mobile Buy sample is now using the compose package, Simple uses the core lib

Before you merge

Important


Checklist for releasing a new version

Tip

See the Contributing documentation for instructions on how to publish a new version of the library.

@kiftio kiftio changed the title Dk/jetpack compose wrapper jetpack compose wrapper Aug 21, 2025
@kiftio kiftio changed the title jetpack compose wrapper Jetpack compose wrapper Aug 21, 2025
@kiftio kiftio marked this pull request as ready for review August 21, 2025 08:14
@kiftio kiftio requested a review from a team as a code owner August 21, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant