Prototype development/android inline component #397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accept app authentication token
|
|
||
| tasks.withType(KotlinJvmCompile).configureEach { | ||
| compilerOptions { | ||
| jvmTarget.set(JvmTarget.JVM_1_8) |
Contributor
Author
There was a problem hiding this comment.
These changes shouldn't have been necessary - I think it was due to the React Native local integration, will remove
kiftio
approved these changes
Nov 13, 2025
kieran-osgood-shopify
deleted the
prototype-development/android-inline-component
branch
kiftio
added a commit
that referenced
this pull request
Nov 14, 2025
* use more specific react-native platform value * Accept an application authentication token (#384) Accept app authentication token * feat: setup android inline component for react-native * fix: add event id to CheckoutAddressChangeRequested * fix: warning on visibility of CheckoutWebViewClient * chore: remove unused private keys * fix: visibility for tests * revert lib/gradle changes * revert jvmOverloads import * refactor: removing redundant modifiers * fix: visibility modifiersa nd add todo --------- Co-authored-by: Daniel Kift <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you making?
This PR exposes the CheckoutWebview as a public export so that it can be rendered in an "inline" mode - this has been tested via integrating into the react native branch which can be found here: Shopify/checkout-sheet-kit-react-native#383
How to test
Run the React Native Android sample app and go to the buy now screen, you should be able to do the same address change flow that occurs in the ios react native app
Before you merge
Important
Checklist for releasing a new version
build.gradlefileTip
See the Contributing documentation for instructions on how to publish a new version of the library.