-
Notifications
You must be signed in to change notification settings - Fork 13
[3.2.0] [Android] Handle geolocation requests #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a3df394 to
bbf5cc4
Compare
bbf5cc4 to
f037c3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 9 changed files in this pull request and generated 1 comment.
Files not reviewed (3)
- modules/@shopify/checkout-sheet-kit/android/gradle.properties: Language not supported
- sample/android/gradle.properties: Language not supported
- README.md: Evaluated as low risk
Comments suppressed due to low confidence (5)
modules/@shopify/checkout-sheet-kit/android/src/main/java/com/shopify/reactnative/checkoutsheetkit/CustomCheckoutEventProcessor.java:83
- Minor spelling mistake in the comment: 'retainGeolocationForFutureRequests' should be 'retainGeolocationForFutureRequests'.
public void onGeolocationPermissionsShowPrompt(@NonNull String origin, @NonNull GeolocationPermissions.Callback callback) {
modules/@shopify/checkout-sheet-kit/android/src/main/java/com/shopify/reactnative/checkoutsheetkit/CustomCheckoutEventProcessor.java:144
- The
HashMapshould specify generic types asHashMap<String, Object>for better type safety.
private Map<String, Object> populateErrorDetails(CheckoutException checkoutError) {
modules/@shopify/checkout-sheet-kit/android/src/main/java/com/shopify/reactnative/checkoutsheetkit/ShopifyCheckoutSheetKitModule.java:287
- The
getConfigandsetConfigmethods are duplicated in the file. This seems unintentional and should be corrected.
public void getConfig(Promise promise) {
modules/@shopify/checkout-sheet-kit/src/index.ts:78
- The type of geolocationCallback should be Maybe to match the return type of addEventListener.
private geolocationCallback: Maybe<EventSubscription>;
modules/@shopify/checkout-sheet-kit/src/index.ts:252
- The requestGeolocation method should handle cases where both permissions are denied explicitly.
const results = await PermissionsAndroid.requestMultiple([coarse, fine]);
...oid/src/main/java/com/shopify/reactnative/checkoutsheetkit/CustomCheckoutEventProcessor.java
Show resolved
Hide resolved
2284e69 to
a5a3560
Compare
e7d2da7 to
67c7678
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 10 changed files in this pull request and generated no comments.
Files not reviewed (4)
- modules/@shopify/checkout-sheet-kit/android/gradle.properties: Language not supported
- sample/android/gradle.properties: Language not supported
- modules/@shopify/checkout-sheet-kit/src/context.tsx: Evaluated as low risk
- sample/src/App.tsx: Evaluated as low risk
67c7678 to
ee73733
Compare
b920239 to
d121244
Compare
d121244 to
d58ea8b
Compare
What changes are you making?
Fixes #129
sequenceDiagram participant Webview participant CheckoutSheetKit participant NativeModule participant App Webview->>CheckoutSheetKit: Request geolocation permissions CheckoutSheetKit->>NativeModule: onGeolocationShowPrompt(origin, callback) NativeModule->>NativeModule: Store origin and callback for later NativeModule->>App: Emit "geolocationRequest" event App->>App: Request geolocation permissions App->>NativeModule: Invoke native callback with result NativeModule->>CheckoutSheetKit: invoke the original promptPR Checklist
Important
package.jsonfile.