#8681 add checkout.paymentMethodChangeStart
#398
+596
−412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kieran-osgood-shopify
changed the title
Coverage Report
|
kieran-osgood-shopify
force-pushed
the
prototype-development/issue-8681-checkout.paymentmethodchangestart2
branch
from
6ee87b9 to
88d6125
Compare
kiftio
reviewed
Nov 27, 2025
| @objc var onLinkClick: RCTBubblingEventBlock? | ||
| @objc var onAddressChangeStart: RCTBubblingEventBlock? | ||
| @objc var onPaymentChangeIntent: RCTBubblingEventBlock? | ||
| @objc var onPaymentMethodChangeStart: RCTBubblingEventBlock? |
Contributor
There was a problem hiding this comment.
do we need to add it to InlineCheckoutEventProcessor?
Contributor
Author
There was a problem hiding this comment.
Yep! moved this back to in draft, I meant to open the android pr as non-draft
kieran-osgood-shopify
force-pushed
the
prototype-development/issue-8681-checkout.paymentmethodchangestart2
branch
from
4eb145d to
f0f8bb9
Compare
Base automatically changed from
prototype-development/inline-android-component
to
prototype/development
November 28, 2025 13:12
kieran-osgood-shopify
changed the title
kieran-osgood-shopify
changed the title
checkout.paymentMethodChangeStart
…-8681-checkout.paymentmethodchangestart2
kieran-osgood-shopify
force-pushed
the
prototype-development/issue-8681-checkout.paymentmethodchangestart2
branch
from
c58840e to
d9a3354
Compare
…-8681-checkout.paymentmethodchangestart2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you making?
Implements
checkout.paymentMethodChangeStartevent from the native libraries:https://github.com/Shopify/checkout-sheet-kit-swift/pull/475/files
https://github.com/Shopify/checkout-sheet-kit-android/pull/425/files
PR Checklist
Important
Releasing a new version of the kit?
package.jsonfile.Tip
See the Contributing documentation for instructions on how to publish a new version of the library.