#8681 add checkout.paymentMethodChangeStart
#398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kieran-osgood-shopify
changed the title
kieran-osgood-shopify
changed the title
checkout.paymentMethodChangeStart
…-8681-checkout.paymentmethodchangestart2
kieran-osgood-shopify
force-pushed
the
prototype-development/issue-8681-checkout.paymentmethodchangestart2
branch
from
c58840e to
d9a3354
Compare
…-8681-checkout.paymentmethodchangestart2
|
|
||
| package com.shopify.reactnative.checkoutsheetkit; | ||
|
|
||
| public enum CheckoutEventType { |
Contributor
Author
There was a problem hiding this comment.
ran into an error where the eventName was being passed wrong and getting mixed up between the prop onPaymentMethodStartChange versus event.type checkout.paymentMethodChangeStart so decided to unify here, comment above says as much but this gives an auto register pattern for the events
kieran-osgood-shopify
force-pushed
the
prototype-development/issue-8681-checkout.paymentmethodchangestart2
branch
from
fcd5faf to
c19e9e6
Compare
| try { | ||
| CheckoutPaymentMethodChangeStartParams params = event.getParams(); | ||
|
|
||
| Map<String, Object> eventData = new HashMap<>(); |
Contributor
Author
There was a problem hiding this comment.
this bits a tad repetitive between the inline/sheet event processors - will perform a follow up to have a factory class for event construction
| const handleError = useCallback< | ||
| Required<NativeCheckoutWebViewProps>['onError'] | ||
| >( | ||
| (event: {nativeEvent: CheckoutException}) => { |
Contributor
Author
There was a problem hiding this comment.
These types on event: {nativeEvent} were duplicative in the end because we already pass the generic into useCallback so was able to remove them
kieran-osgood-shopify
force-pushed
the
prototype-development/issue-8681-checkout.paymentmethodchangestart2
branch
from
c19e9e6 to
500215d
Compare
…-8681-checkout.paymentmethodchangestart2
kiftio
reviewed
Dec 2, 2025
...roid/src/main/java/com/shopify/reactnative/checkoutsheetkit/SheetCheckoutEventProcessor.java
Outdated
Show resolved
Hide resolved
...roid/src/main/java/com/shopify/reactnative/checkoutsheetkit/SheetCheckoutEventProcessor.java
Show resolved
Hide resolved
kieran-osgood-shopify
force-pushed
the
prototype-development/issue-8681-checkout.paymentmethodchangestart2
branch
from
e45705f to
45c5e91
Compare
kiftio
approved these changes
Dec 3, 2025
kieran-osgood-shopify
deleted the
prototype-development/issue-8681-checkout.paymentmethodchangestart2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you making?
Implements
checkout.paymentMethodChangeStartevent from the native libraries:https://github.com/Shopify/checkout-sheet-kit-swift/pull/475/files
https://github.com/Shopify/checkout-sheet-kit-android/pull/425/files
Screen.Recording.2025-12-01.at.13.46.20.mov
PR Checklist
Important
Releasing a new version of the kit?
package.jsonfile.Tip
See the Contributing documentation for instructions on how to publish a new version of the library.