Skip to content

bump android and fix processor constructor #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kiftio wants to merge 1 commit into from
Closed

bump android and fix processor constructor #412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/@shopify/checkout-sheet-kit/android/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ ndkVersion=23.1.7779620
buildToolsVersion = "35.0.0"

# Version of Shopify Checkout SDK to use with React Native
SHOPIFY_CHECKOUT_SDK_VERSION=4.0.0-SNAPSHOT
SHOPIFY_CHECKOUT_SDK_VERSION=4.0.1-SNAPSHOT
10 changes: 1 addition & 9 deletions ...it/android/src/main/java/com/shopify/reactnative/checkoutsheetkit/RCTCheckoutWebView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,6 @@ of this software and associated documentation files (the "Software"), to deal
import java.util.Map;
import java.util.Objects;

import kotlin.Unit;

public class RCTCheckoutWebView extends FrameLayout {
private static final String TAG = "RCTCheckoutWebView";
private final ThemedReactContext context;
Expand Down Expand Up @@ -195,13 +193,7 @@ private CheckoutWebViewEventProcessor getCheckoutWebViewEventProcessor() {
Activity currentActivity = this.context.getCurrentActivity();
InlineCheckoutEventProcessor eventProcessor = new InlineCheckoutEventProcessor(currentActivity);

return new CheckoutWebViewEventProcessor(
eventProcessor,
(visible) -> Unit.INSTANCE, // toggleHeader
(error) -> Unit.INSTANCE, // closeCheckoutDialogWithError
(visibility) -> Unit.INSTANCE, // setProgressBarVisibility
(percentage) -> Unit.INSTANCE // updateProgressBarPercentage
);
return new CheckoutWebViewEventProcessor(eventProcessor);
}

void removeCheckout() {
Expand Down
2 changes: 1 addition & 1 deletion sample/android/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,4 @@ newArchEnabled=true
hermesEnabled=true

# Note: only used here for testing
SHOPIFY_CHECKOUT_SDK_VERSION=4.0.0-SNAPSHOT
SHOPIFY_CHECKOUT_SDK_VERSION=4.0.1-SNAPSHOT
2 changes: 1 addition & 1 deletion scripts/publish_android_snapshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
set -e

SDK_PATH="${1:-$HOME/src/github.com/Shopify/checkout-sheet-kit-android}"
VERSION="${2:-4.0.0-SNAPSHOT}"
VERSION="${2:-4.0.1-SNAPSHOT}"

if [ ! -d "$SDK_PATH" ]; then
echo "Error: checkout-sheet-kit-android not found at $SDK_PATH"
Expand Down
Loading