feat: add types to respondWith #423
Open
+20
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
|
markmur
approved these changes
Jan 13, 2026
Comment on lines
+59
to
+62
| async ( | ||
| eventId: string, | ||
| response: CheckoutEventResponsePayload, | ||
| ): Promise<boolean> => { |
Contributor
There was a problem hiding this comment.
Does this function need to be async? The contents look synchronous to me, unless the UIManager calls are async but we're not awaiting them
Contributor
Author
There was a problem hiding this comment.
Good point - no longer needs async (previously did)
I'm used to eslint catching that I'm setting up another PR with typescript-eslint so I can add require-await to avoid this mistake in future
josemiguel-alvarez
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you making?
Add's respondWith types
PR Checklist
Important
Releasing a new version of the kit?
package.jsonfile.Tip
See the Contributing documentation for instructions on how to publish a new version of the library.