Skip to content

Commit ac7f9b2

Browse files
authored
Merge pull request #13 from shopify-playground/ec-remove-3.0
Ruby 3.0 is incompatible for building fat gems on Windows:
2 parents 87b7fe9 + 1b778a9 commit ac7f9b2

File tree

6 files changed

+7
-9
lines changed

6 files changed

+7
-9
lines changed

.github/workflows/gem-compile.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ jobs:
2828
- name: "Setup Ruby"
2929
uses: "ruby/setup-ruby@v1"
3030
with:
31-
ruby-version: "3.0.7"
31+
ruby-version: "3.1.7"
3232
bundler-cache: true
3333
working-directory: "test/fixtures/date"
3434
- name: "Run easy compile"

lib/easy_compile/ruby_series.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ def cross_rubies
3737
Gem::Version.new("3.3.8"),
3838
Gem::Version.new("3.2.8"),
3939
Gem::Version.new("3.1.6"),
40-
Gem::Version.new("3.0.6"),
4140
]
4241
end
4342

@@ -47,7 +46,6 @@ def latest_rubies
4746
Gem::Version.new("3.3.9"),
4847
Gem::Version.new("3.2.9"),
4948
Gem::Version.new("3.1.7"),
50-
Gem::Version.new("3.0.7"),
5149
]
5250
end
5351
end

test/cli_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ def test_print_ruby_cc_version
115115
end
116116
end
117117

118-
assert_equal("3.4.6:3.3.8:3.2.8:3.1.6:3.0.6", out)
118+
assert_equal("3.4.6:3.3.8:3.2.8:3.1.6", out)
119119
end
120120

121121
def test_when_cli_runs_in_project_with_no_gemspec

test/fixtures/expected_github_workflow.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
- name: "Setup Ruby"
2222
uses: "ruby/setup-ruby@v1"
2323
with:
24-
ruby-version: "3.0.7"
24+
ruby-version: "3.1.7"
2525
bundler-cache: true
2626
- name: "Run easy compile"
2727
uses: "shopify-playground/edouard-playground/.github/actions/easy_compile@main"
@@ -35,7 +35,7 @@ jobs:
3535
strategy:
3636
matrix:
3737
os: ["macos-latest", "ubuntu-latest"]
38-
rubies: ["3.4.7", "3.3.9", "3.2.9", "3.1.7", "3.0.7"]
38+
rubies: ["3.4.7", "3.3.9", "3.2.9", "3.1.7"]
3939
type: ["cross", "native"]
4040
runs-on: "${{ matrix.os }}"
4141
steps:

test/fixtures/expected_github_workflow_working_dir.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
- name: "Setup Ruby"
2222
uses: "ruby/setup-ruby@v1"
2323
with:
24-
ruby-version: "3.0.7"
24+
ruby-version: "3.1.7"
2525
bundler-cache: true
2626
working-directory: "test/fixtures/date"
2727
- name: "Run easy compile"
@@ -37,7 +37,7 @@ jobs:
3737
strategy:
3838
matrix:
3939
os: ["macos-latest", "ubuntu-latest"]
40-
rubies: ["3.4.7", "3.3.9", "3.2.9", "3.1.7", "3.0.7"]
40+
rubies: ["3.4.7", "3.3.9", "3.2.9", "3.1.7"]
4141
type: ["cross", "native"]
4242
runs-on: "${{ matrix.os }}"
4343
steps:

test/ruby_series_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ def test_runtime_version_for_compilation
3131
def test_latest_version_for_compilation_multiple
3232
requirements = Gem::Requirement.new("> 3")
3333

34-
assert_equal("3.0.7", RubySeries.runtime_version_for_compilation(requirements).to_s)
34+
assert_equal("3.1.7", RubySeries.runtime_version_for_compilation(requirements).to_s)
3535
end
3636

3737
def test_versions_to_compile_against

0 commit comments

Comments
 (0)