Parse the extconf instead of running it: #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Loading the extconf.rb file was required as we need to be able to detect the `create_makefile` call in order to know the resultin binary name (the first argument to the method). We need to know the resulting binary name in order to properly setup rake compiler. Running the extconf was really hacky so instead we'll parse it with Prism.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse the extconf instead of running it:
Loading the extconf.rb file was required as we need to be able to detect the
create_makefilecall in order to know the resultin binary name (the first argument to the method). We need to know the resulting binary name in order to properly setup rake compiler.Running the extconf was really hacky so instead we'll parse it with Prism.