Update theme delete command for multi-environment

Previously `theme delete` command could only be run
in a single environment at a time. This commit allows
`delete`to be run in multiple environments in a
single command run

Author: dejmedus

.changeset/silver-worms-punch.md

@@ -0,0 +1,5 @@
+---
+'@shopify/theme': minor
+---
+
+Allow theme delete command to be called with multiple environments

packages/cli/oclif.manifest.json

@@ -5291,10 +5291,18 @@
       "hiddenAliases": [
       ],
       "id": "theme:delete",
+      "multiEnvironmentsFlags": [
+        "store",
+        "password",
+        [
+          "development",
+          "theme"
+        ]
+      ],
       "pluginAlias": "@shopify/cli",
       "pluginName": "@shopify/cli",
       "pluginType": "core",
-      "strict": false,
+      "strict": true,
       "summary": "Delete remote themes from the connected store. This command can't be undone."
     },
     "theme:dev": {

packages/theme/src/cli/commands/theme/delete.ts

@@ -1,11 +1,12 @@
-import {ensureThemeStore} from '../../utilities/theme-store.js'
 import ThemeCommand from '../../utilities/theme-command.js'
 import {themeFlags} from '../../flags.js'
 import {themesDelete} from '../../services/delete.js'
 import {Flags} from '@oclif/core'
 import {globalFlags} from '@shopify/cli-kit/node/cli'
-import {ensureAuthenticatedThemes} from '@shopify/cli-kit/node/session'
+import {OutputFlags} from '@oclif/core/interfaces'
+import {AdminSession} from '@shopify/cli-kit/node/session'
 
+type DeleteFlags = OutputFlags<typeof Delete.flags>
 export default class Delete extends ThemeCommand {
   static summary = "Delete remote themes from the connected store. This command can't be undone."
 
@@ -43,19 +44,22 @@ export default class Delete extends ThemeCommand {
     }),
   }
 
-  async run(): Promise<void> {
-    const {flags} = await this.parse(Delete)
-    const {development, force, password, theme} = flags
-    const themes = [...(theme ?? [])]
+  static multiEnvironmentsFlags = ['store', 'password', ['development', 'theme']]
 
-    const store = ensureThemeStore(flags)
-    const adminSession = await ensureAuthenticatedThemes(store, password)
+  async command(flags: DeleteFlags, adminSession: AdminSession, multiEnvironment: boolean) {
+    const {environment, development, force, theme} = flags
+    const themes = theme ?? []
 
-    await themesDelete(adminSession, {
-      selectTheme: flags['show-all'],
-      development,
-      themes,
-      force,
-    })
+    await themesDelete(
+      adminSession,
+      {
+        selectTheme: flags['show-all'],
+        environment,
+        development,
+        themes,
+        force,
+      },
+      multiEnvironment,
+    )
   }
 }

packages/theme/src/cli/services/delete.ts

@@ -17,12 +17,13 @@ import {isDevelopmentTheme} from '@shopify/cli-kit/node/themes/utils'
 
 interface DeleteOptions {
   selectTheme: boolean
+  environment?: string[]
   development: boolean
   force: boolean
   themes: string[]
 }
 
-export async function themesDelete(adminSession: AdminSession, options: DeleteOptions) {
+export async function themesDelete(adminSession: AdminSession, options: DeleteOptions, multiEnvironment?: boolean) {
   let themeIds = options.themes
   if (options.development) {
     const theme = await new DevelopmentThemeManager(adminSession).find()
@@ -32,7 +33,7 @@ export async function themesDelete(adminSession: AdminSession, options: DeleteOp
   const store = adminSession.storeFqdn
   const themes = await findThemesByDeleteOptions(adminSession, {...options, themes: themeIds, development: false})
 
-  if (!options.force && !(await isConfirmed(themes, store))) {
+  if (!options.force && !multiEnvironment && !(await isConfirmed(themes, store))) {
     return
   }
 
@@ -45,11 +46,13 @@ export async function themesDelete(adminSession: AdminSession, options: DeleteOp
     }),
   )
 
+  const environment = options.environment ? [{subdued: `Environment: ${options.environment}\n\n`}] : []
+
   renderSuccess({
     body: pluralize(
       themes,
-      (themes) => [`The following themes were deleted from ${store}:`, themesComponent(themes)],
-      (theme) => ['The theme', ...themeComponent(theme), `was deleted from ${store}.`],
+      (themes) => [...environment, `The following themes were deleted from ${store}:`, themesComponent(themes)],
+      (theme) => [...environment, 'The theme', ...themeComponent(theme), `was deleted from ${store}.`],
     ),
   })
 }