Make build optional in the schema

Author: gonzaloriestra

packages/app/src/cli/models/extensions/extension-instance.ts

@@ -303,7 +303,7 @@ export class ExtensionInstance<TConfiguration extends BaseConfigType = BaseConfi
   get watchBuildPaths() {
     if (this.isFunctionExtension) {
       const config = this.configuration as unknown as FunctionConfigType
-      const configuredPaths = config.build.watch ? [config.build.watch].flat() : []
+      const configuredPaths = config.build?.watch ? [config.build.watch].flat() : []
 
       if (!this.isJavaScript && configuredPaths.length === 0) {
         return null

packages/app/src/cli/models/extensions/specifications/function.test.ts

@@ -305,4 +305,27 @@ describe('functionConfiguration', () => {
       expect(got.ui?.ui_extension_handle).toBeUndefined()
     })
   })
+
+  test('accepts configuration without build section', async () => {
+    // Given
+    const configWithoutBuild = {
+      name: 'function',
+      type: 'function',
+      metafields: [],
+      description: 'my function',
+      // build section is omitted
+      configuration_ui: false,
+      api_version: '2022-07',
+    }
+
+    // When
+    const extension = await testFunctionExtension({
+      dir: '/function',
+      config: configWithoutBuild as FunctionConfigType,
+    })
+
+    // Then
+    expect(extension.configuration.build).toBeUndefined()
+    expect(extension.outputPath).toBe(joinPath('/function', 'dist', 'index.wasm'))
+  })
 })

packages/app/src/cli/models/extensions/specifications/function.ts

@@ -18,15 +18,17 @@ interface UI {
 
 export type FunctionConfigType = zod.infer<typeof FunctionExtensionSchema>
 const FunctionExtensionSchema = BaseSchema.extend({
-  build: zod.object({
-    command: zod
-      .string()
-      .transform((value) => (value.trim() === '' ? undefined : value))
-      .optional(),
-    path: zod.string().optional(),
-    watch: zod.union([zod.string(), zod.string().array()]).optional(),
-    wasm_opt: zod.boolean().optional().default(true),
-  }),
+  build: zod
+    .object({
+      command: zod
+        .string()
+        .transform((value) => (value.trim() === '' ? undefined : value))
+        .optional(),
+      path: zod.string().optional(),
+      watch: zod.union([zod.string(), zod.string().array()]).optional(),
+      wasm_opt: zod.boolean().optional().default(true),
+    })
+    .optional(),
   name: zod.string(),
   type: zod.string(),
   configuration_ui: zod.boolean().optional().default(true),

packages/app/src/cli/services/build/extension.test.ts

@@ -48,7 +48,7 @@ describe('buildFunctionExtension', () => {
 
   test('delegates the build to system when the build command is present', async () => {
     // Given
-    extension.configuration.build.command = './scripts/build.sh argument'
+    extension.configuration.build!.command = './scripts/build.sh argument'
 
     // When
     await expect(
@@ -73,7 +73,7 @@ describe('buildFunctionExtension', () => {
 
   test('fails when is not a JS function and build command is not present', async () => {
     // Given
-    extension.configuration.build.command = undefined
+    extension.configuration.build!.command = undefined
 
     // Then
     await expect(
@@ -91,7 +91,7 @@ describe('buildFunctionExtension', () => {
   test('succeeds when is a JS function and build command is not present', async () => {
     // Given
     extension = await testFunctionExtension({config: defaultConfig, entryPath: 'src/index.js'})
-    extension.configuration.build.command = undefined
+    extension.configuration.build!.command = undefined
 
     // When
     await expect(
@@ -118,7 +118,7 @@ describe('buildFunctionExtension', () => {
   test('succeeds when is a JS function and build command is present', async () => {
     // Given
     extension = await testFunctionExtension({config: defaultConfig, entryPath: 'src/index.js'})
-    extension.configuration.build.command = './scripts/build.sh argument'
+    extension.configuration.build!.command = './scripts/build.sh argument'
 
     // When
     await expect(
@@ -182,7 +182,7 @@ describe('buildFunctionExtension', () => {
   test('skips wasm-opt execution when the disable-wasm-opt is true', async () => {
     // Given
     vi.mocked(fileExistsSync).mockResolvedValue(true)
-    extension.configuration.build.wasm_opt = false
+    extension.configuration.build!.wasm_opt = false
 
     // When
     await expect(