Skip to content

Conversation

nickwesselman
Copy link
Contributor

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@nickwesselman
Copy link
Contributor Author

/snapit

1 similar comment
@nickwesselman
Copy link
Contributor Author

/snapit

@nickwesselman
Copy link
Contributor Author

/snapit

@nickwesselman
Copy link
Contributor Author

/snapit

Copy link
Contributor

Unused dependencies (2)

Filename dependencies
packages/app/package.json @shopify/plugin-ngrok
packages/plugin-ngrok/package.json @oclif/core

Unused types (1)

Filename types
packages/app/src/cli/services/dev/tunnel-mode.ts NgrokTunnel

Copy link
Contributor

🫰✨ Thanks @nickwesselman! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

pnpm i -g @shopify/[email protected]

Tip

If you get an ETARGET error, install it with NPM and the flag --@shopify:registry=https://registry.npmjs.org

Caution

After installing, validate the version by running just shopify in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.08% (-0.19% 🔻)
13133/16821
🟡 Branches
72.26% (-0.01% 🔻)
6402/8860
🟡 Functions
78.15% (-0.2% 🔻)
3408/4361
🟡 Lines
78.44% (-0.21% 🔻)
12430/15846
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / provider.ts
0% 100% 100% 0%
🔴
... / tunnel.ts
0% 0% 0% 0%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / dev.ts
11.29% (-0.28% 🔻)
12% (-0.33% 🔻)
12.12%
12.07% (-0.32% 🔻)
🟢
... / tunnel-mode.ts
92.31% (-7.69% 🔻)
92.86% (-7.14% 🔻)
100%
92.31% (-7.69% 🔻)

Test suite run success

3104 tests passing in 1320 suites.

Report generated by 🧪jest coverage report action from 653b1d8

Copy link
Contributor

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant