-
Notifications
You must be signed in to change notification settings - Fork 207
Fetch and copy AI instructions from theme-liquid-docs #6234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8170ba3
to
c9f3b5e
Compare
c9f3b5e
to
a8a4854
Compare
Coverage report
Show files with reduced coverage 🔻
Test suite run success3149 tests passing in 1328 suites. Report generated by 🧪jest coverage report action from 9b872dc |
/snapit |
🫰✨ Thanks @graygilmore! Your snapshot has been published to npm. Test the snapshot by installing your package globally: pnpm i -g @shopify/[email protected] Tip If you get an Caution After installing, validate the version by running just |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎩 went great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR, @aswamy! 🚀 I've left only one minor suggestion and one question. Please let me know your thoughts about them :)
1676d38
to
696bfbf
Compare
696bfbf
to
9b872dc
Compare
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/fs.d.ts@@ -329,4 +329,11 @@ export declare function matchGlob(key: string, pattern: string, options?: MatchG
* @returns A promise that resolves to an array of file names.
*/
export declare function readdir(path: string): Promise<string[]>;
+/**
+ * Copies the contents of a directory to another directory.
+ *
+ * @param srcDir - Source directory path.
+ * @param destDir - Destination directory path.
+ */
+export declare function copyDirectoryContents(srcDir: string, destDir: string): Promise<void>;
export {};
\ No newline at end of file
|
WHY are these changes introduced?
.github
,.cursor
, and.claude
directories if it's NOT a skeleton theme--clone-url
flag), we shouldn't be removing directoriesWHAT is this pull request doing?
How to test your changes?
Initializing Skeleton Theme
shopify theme init
.github
,.cursor, or
.claude` that contains AI instructionsInitializing non-Skeleton Theme
shopify theme init --clone-url "https://github.com/shopify-playground/alok-sandbox"
.github
,.cursor, and
.claude` directories are NOT deletedPost-release steps
n/a
Measuring impact
How do we know this change was effective? Please choose one:
Checklist