-
Notifications
You must be signed in to change notification settings - Fork 224
feat(graphiql): add base UI components #6580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(graphiql): add base UI components #6580
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report
Test suite run success3399 tests passing in 1391 suites. Report generated by 🧪jest coverage report action from cb351dd |
106240c to
ece610f
Compare
b199d75 to
f14423d
Compare
ece610f to
b31bbbe
Compare
f14423d to
2fd515e
Compare
b31bbbe to
4ff63c5
Compare
4ff63c5 to
47297ec
Compare
2fd515e to
8c2c496
Compare
d2a007d to
f3f94ef
Compare
8c2c496 to
fdf8d16
Compare
f3f94ef to
e4e87e9
Compare
1c51420 to
1e1e3f6
Compare
db5e515 to
0cd0b46
Compare
1e1e3f6 to
d5b6f9a
Compare
45c17b5 to
d34bd65
Compare
d5b6f9a to
3274ef0
Compare
Adds simple, self-contained UI components using Shopify Polaris. - Add StatusBadge component with connection status display - Add ErrorBanner component for error messaging - Add LinkPills component for store/app links - Include comprehensive tests (173 lines) All component tests pass
d34bd65 to
cb351dd
Compare
3274ef0 to
9296984
Compare
|
This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. |

WHY are these changes introduced?
This PR builds on PRs #6578 and #6579 by adding the foundational UI components that will be used throughout the GraphiQL console. This is the third PR in the 8-PR migration stack.
Context: The current template-based GraphiQL implementation manipulates the DOM directly and uses CSS toggling to show/hide status indicators. By creating reusable React components using Shopify Polaris, we can:
WHAT is this pull request doing?
This PR adds three essential UI components that handle status display, error messaging, and navigation links.
Key Changes:
1. StatusBadge Component (
src/components/StatusBadge/):Badgewith appropriate tones and iconsVisual States:
2. ErrorBanner Component (
src/components/ErrorBanner/):devCLI commandBannerwith critical tone3. LinkPills Component (
src/components/LinkPills/):storeFqdn,appName,appUrl)Badge+Linkwith info tone and link iconAll Components Include:
Files Added:
src/components/StatusBadge/- Status display component (58 test lines)src/components/ErrorBanner/- Error messaging component (42 test lines)src/components/LinkPills/- Navigation links component (73 test lines)Dependencies
Builds on:
ServerStatusinterface)How to test your changes?
Manual Testing:
You can test the components in isolation by importing them into the App component:
Measuring impact
Checklist