Skip to content

Clean up CI workflows#6600

Merged
gonzaloriestra merged 1 commit intomainfrom
clean-up-workflows
Nov 12, 2025
Merged

Clean up CI workflows#6600
gonzaloriestra merged 1 commit intomainfrom
clean-up-workflows

Conversation

@gonzaloriestra
Copy link
Contributor

@gonzaloriestra gonzaloriestra commented Nov 11, 2025

WHY are these changes introduced?

The current shopify-cli workflow is too messy and has some problems.

WHAT is this pull request doing?

  • Simplifies the file by extracting code to 2 new files: cli-manual and cli-main
  • Knip and lint failures are now shown right there, instead of spreading them as inline-comments. Many people were confused by this, because the errors weren't easy to find.
Knip Lint
knip lint
  • Some tasks were incorrectly grouped under CLA
cla checks
  • Tests were being skipped on PRs only including changes in MD files, but the tests are required to merge, so it was confusing as well. Now it always runs them.
  • Renamed some jobs to simplify and make it clearer. Removed unneeded shopify-cli references and clarified what other tasks like knip do.
  • Removed some checks about dependabot or forks. As knip and lint don't need to comment on the PR anymore, the required checks will work everywhere.

Once this is merged, I'll update the required checks in the repository settings.

How to test your changes?

CI

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.23% (+0.01% 🔼)
13582/17143
🟡 Branches
73.11% (+0.01% 🔼)
6631/9070
🟡 Functions 79.37% 3505/4416
🟡 Lines
79.58% (+0.01% 🔼)
12827/16118

Test suite run success

3356 tests passing in 1372 suites.

Report generated by 🧪jest coverage report action from 0eca8eb

@gonzaloriestra gonzaloriestra force-pushed the clean-up-workflows branch 2 times, most recently from 57f735d to 97e8e07 Compare November 11, 2025 13:27
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to rename this to cli-pr.yml, but GH is not showing properly the diff in that case, so I'll change it in another PR.

@gonzaloriestra gonzaloriestra marked this pull request as ready for review November 11, 2025 15:27
@gonzaloriestra gonzaloriestra requested a review from a team as a code owner November 11, 2025 15:27
@gonzaloriestra gonzaloriestra merged commit 30fb5a7 into main Nov 12, 2025
24 checks passed
@gonzaloriestra gonzaloriestra deleted the clean-up-workflows branch November 12, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants