Fix extension matching to support external identifiers#7160
Fix extension matching to support external identifiers#7160isaacroldan merged 3 commits intomainfrom
Conversation
ae6186b to
6ef9188
Compare
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
There was a problem hiding this comment.
Pull request overview
Updates the deploy/release breakdown logic to correctly recognize extension app modules whose specification.identifier is an external identifier, so they are categorized correctly during deploy/release flows.
Changes:
- Extend extension-module/spec matching to accept
spec.externalIdentifieras a match forappModuleVersion.specification.identifier. - Add a regression test covering an active app version module identified via a spec external identifier.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/app/src/cli/services/context/breakdown-extensions.ts | Adjusts spec matching when filtering active app modules so extension modules can be recognized by external identifiers. |
| packages/app/src/cli/services/context/breakdown-extensions.test.ts | Adds test coverage to ensure external-identifier module specs are treated as unchanged CLI extensions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Claude Code <claude-code@anthropic.com>
Co-authored-by: Claude Code <claude-code@anthropic.com>
Co-authored-by: Claude Code <claude-code@anthropic.com>
7e48002 to
d562fdc
Compare

WHY are these changes introduced?
Extension matching was failing when comparing local extension specifications with remote app module versions that use external identifiers, causing extensions to be incorrectly categorized during deployment breakdown.
WHAT is this pull request doing?
Updates the extension matching logic in
loadExtensionsIdentifiersBreakdownto check both the standardidentifierandexternalIdentifierfields when comparing local specs against remote app module specifications. This ensures extensions with external identifiers are properly recognized as unchanged rather than being marked for creation or update.How to test your changes?
Measuring impact
How do we know this change was effective? Please choose one:
Checklist