Skip to content

fix: update spacing in MethodCard component #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bolariin wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: update spacing in MethodCard component #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
718080a
fix: update spacing in MethodCard component
bolariin Nov 13, 2023
ef1822c
Fix tests
bolariin Jul 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fifty-waves-glow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/discount-app-components': patch
---

Update spacing in MethodCard component
2 changes: 1 addition & 1 deletion src/components/MethodCard/MethodCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ export function MethodCard({
<Box paddingBlockEnd="400">
<Card padding="400">
<BlockStack gap="400">
<InlineStack align="start" blockAlign="center" gap="100">
<InlineStack align="space-between" blockAlign="center">
<Text variant="headingMd" as="h2">
{title}
</Text>
Expand Down
5 changes: 2 additions & 3 deletions src/components/MethodCard/tests/MethodCard.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,16 +40,15 @@ describe('<MethodCard />', () => {
});
});

it('renders the title align start and blockAlign center', () => {
it('renders the title align space-between and blockAlign center', () => {
const methodCard = mountWithApp(<MethodCard {...mockProps} />);

expect(methodCard).toContainReactComponent(Card, {
padding: '400',
});
expect(methodCard).toContainReactComponent(InlineStack, {
align: 'start',
align: 'space-between',
blockAlign: 'center',
gap: '100',
});
});

Expand Down