Conversation
hamishmorgan
reviewed
Jul 4, 2025
Contributor
hamishmorgan
left a comment
hamishmorgan
left a comment
There was a problem hiding this comment.
A couple nits. Main blocker is you committed the generated files too.
functions-cart-checkout-validation-js/shopify.extension.toml.liquid
Outdated
Show resolved
Hide resolved
functions-cart-checkout-validation-js/src/cart_validations_generate_run.liquid
Outdated
Show resolved
Hide resolved
functions-cart-checkout-validation-js/src/cart_validations_generate_run.test.ts
Outdated
Show resolved
Hide resolved
ginmrt
changed the title
tjoyal
commented
Jul 4, 2025
tjoyal
commented
Jul 4, 2025
Member
Author
tjoyal
left a comment
tjoyal
left a comment
There was a problem hiding this comment.
✅ but can't approve in Github since I'm the original author of the PR
ginmrt
approved these changes
Jul 4, 2025
functions-cart-checkout-validation-js/shopify.extension.toml.liquid
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The 2025-07 API version has been released and contained breaking or meaningful changes for many functions. The code examples here need to be updated.
Solution
Update Validation and Payment Customization code examples for all languages to follow the latest 2025-07 API version updates.
Checklist