Conversation
adampetro
reviewed
Jul 4, 2025
Comment on lines
+38
to
+41
| case "typescript": | ||
| case "vanilla-js": | ||
| pathSuffix = "js"; | ||
| break; |
Contributor
There was a problem hiding this comment.
I don't think this works for this one outlier which uses a separate -ts suffix for some reason. Maybe we want to make this a pattern/regex somehow?
Member
Author
There was a problem hiding this comment.
Hmm good point, let me have a look. I don't think my code change have any impact on what you mention, but might as well try to fix it at the same time.
adampetro
approved these changes
Jul 7, 2025
davejcameron
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
There was no way to expand
wasmexample liquid files.Solution
Add support to
yarn expand-liquid wasmIt's not quite doing anything else than that for now (no actual CI steps) but it's a start toward parity of
wasmwith the rest.Checklist