Merged
Conversation
def4c79 to
73c2971
Compare
saga-dasgupta
left a comment
There was a problem hiding this comment.
I think you haven't removed the rust unit tests.
2 tasks
saga-dasgupta
approved these changes
Dec 10, 2025
saga-dasgupta
left a comment
There was a problem hiding this comment.
Tested and verified that all the unit tests have been replaced by fixtures and all the fixtures pass for cart validation, cart transform, delivery customization, discount and discount allocator functions for both Rust and JS.
achitojha
approved these changes
Dec 10, 2025
Contributor
achitojha
left a comment
There was a problem hiding this comment.
Verified all extension tests succeed and use the respective json files for Rust & Javascript versions of "Fulfillment constraint" / "Local pickup delivery option generator" / "Pickup point delivery option generator" / "Payment customization"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Fixes https://github.com/shop/issues-shopifyvm/issues/765
Converts existing unit tests to integration tests instead.
Also covers the rust side of https://github.com/shop/issues-shopifyvm/issues/755
Solution
Create a fixture representing each of the existing unit test scenarios.
Tophat
Run the generate command targetting this branch
Checklist