add base version to be 2026-01 in the templates #362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanhamel4
force-pushed
the
jh/fix-base-version-for-discount-api
branch
from
0e79712 to
4c63629
Compare
jonathanhamel4
force-pushed
the
jh/fix-base-version-for-discount-api
branch
from
4c63629 to
e257766
Compare
devisscher
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
When doing the discount rejection tutorial, we use the
discounttemplate which is set on 2025-04 by default. This means anyone following the tutorial will encounter issues when trying to readenteredDiscountCodessince they are on an outdated version. 2026-01 is when this feature was released.I tested those changes in Discount Functions Testing and they all compile well after simply changing the api version + schema.