Clarify values to be given for estimatedItemSize #1030
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a bullet point to the docs making it clear what values are to be used for estimatedItemSize
|
Hi! 👋 Thank you for your contribution to FlashList! We're now focusing exclusively on FlashList v2 and React Native's New Architecture. As part of this transition, we're closing older pull requests to better focus our review efforts on v2-compatible changes. If your changes are still relevant:
Resources: We truly appreciate your effort and contribution. Thank you for helping make FlashList better! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a bullet point to the docs making it clear what values are to be used for estimatedItemSize. When I was learning FlashList I wasn't sure what single number should be passed in for estimatedItemSize. It was only when I read the comments in the code that this was clarified. I feel that this is important information that should be added in the current documentation.