Skip to content

Conversation

zyestin
Copy link

@zyestin zyestin commented Nov 27, 2024

I am glad to see that @Paduado has added the recomputeViewableItems method to solve the problem that the onViewableItemsChanged will not be called after the FlashList's data is updated.
But the MasonryFlashList I used in my project did not enjoy this benefit.
So I changed the MasonryFlashList source code to achieve the same effect as FlashList.

Reviewers’ hat-rack 🎩

  • Validate that calling the recomputeViewableItems method triggers the onViewableItemsChanged callback.

Screenshots or videos (if needed)

Checklist

@zyestin
Copy link
Author

zyestin commented Nov 27, 2024

I have signed the CLA!

@zyestin
Copy link
Author

zyestin commented Dec 2, 2024

Hi, @naqvitalha. Can you review my commit, which is very relevant to the last PR #1296 you were involved.

@naqvitalha
Copy link
Collaborator

Hi! 👋 Thank you for your contribution to FlashList!

We're now focusing exclusively on FlashList v2 and React Native's New Architecture. As part of this transition, we're closing older pull requests to better focus our review efforts on v2-compatible changes.

If your changes are still relevant:

  • Please verify they work with FlashList v2
  • Rebase against the latest main branch
  • Open a new PR with v2 compatibility in mind
  • We'll be happy to review it!

Resources:

We truly appreciate your effort and contribution. Thank you for helping make FlashList better! 🙏

@naqvitalha naqvitalha closed this Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants