Skip to content

Conversation

@fredericoo
Copy link
Contributor

@fredericoo fredericoo commented Jan 7, 2026

ps.: we might want to add more than tsx, i see lots of js files in the source

pps.: why do we have js files in the source, could we not compile the ts(x) → js(x) for the js version?

WHY are these changes introduced?

To ensure that TSX files are properly included as inputs for the build task in the Turbo configuration.

WHAT is this pull request doing?

Adds src/**/*.tsx to the inputs array for the build task in turbo.json, allowing Turbo to properly track changes in TSX files when determining whether to rebuild.

HOW to test your changes?

  1. Make changes to a TSX file in the src directory
  2. Run a build using Turbo
  3. Verify that changes to TSX files trigger rebuilds appropriately

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@shopify
Copy link
Contributor

shopify bot commented Jan 7, 2026

Oxygen deployed a preview of your 01-07-fix_tsx_files_not_busting_turborepo_cache_for_build_commands branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment January 7, 202611:57 AM

Learn more about Hydrogen's GitHub integration.

@fredericoo fredericoo marked this pull request as ready for review January 7, 2026 11:59
@fredericoo fredericoo requested a review from a team as a code owner January 7, 2026 11:59
Copy link
Contributor

@frandiox frandiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

ps.: we might want to add more than tsx, i see lots of js files in the source
pps.: why do we have js files in the source, could we not compile the ts(x) → js(x) for the js version?

I think the *.js files are mostly for docs and examples. These files are used to generate *.json files that are later used in our dev docs.

I believe the reason it was setup like that is to have more flexibility to change JS examples, instead of them being auto-generated.... but tbh I would prefer if they were auto-generated and prettified properly. And maybe move them outside of the source code to a different place, but I'm not sure about the constraints we had when making it this way.

Copy link
Contributor Author

got it! not a super important change

caching as always comes with a lot of caveats, i aded .tsx but the true solution should include all the config files, and be per-package as for instance the CLI should miss the cache if the skeleton template changes, etc etc

my solution is naive but covers most of our changes, and also im assuming we dont use remote cache from turbo, so this only affects local dev

@frandiox frandiox merged commit 7c7929a into main Jan 7, 2026
12 checks passed
@frandiox frandiox deleted the 01-07-fix_tsx_files_not_busting_turborepo_cache_for_build_commands branch January 7, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants