-
Notifications
You must be signed in to change notification settings - Fork 377
chore(deps): bump RR7 to v7.12.0 #3346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
fredericoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
frandiox
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should wait to merge this until cookies are released?
| }, | ||
| "prettier": "@shopify/prettier-config", | ||
| "dependencies": { | ||
| "@shopify/hydrogen": "2025.7.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know y'all's release flow, will this PR bump the @shopify/hydrogen version? If so, does this dep also need to be bumped in the various package.json?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So merging this PR won't release anything, but it will update this 2025.7.1 release PR. And merging that 2025.7.1 release PR will actually publish the new Hydrogen version on npm, and also update this dependency here automatically to 2025.7.1 :)
brookslybrand
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I just had one question
| "graphql": "^16.10.0", | ||
| "graphql-tag": "^2.12.6", | ||
| "isbot": "^5.1.22", | ||
| + "morgan": "^1.10.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite sure what these patches are for but we recently updated compression/morgan to address an underlying CVE (remix-run/react-router#14652) so if they are being patched it should meet those new minimum versions. But ideally they don't need to be patched?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, these patches are just used as "recipes" in the dev docs. Here is the link to this specific one. I will bump this morgan version in the express recipe as a follow-up so it reflects best practices for security :) Thanks Matt!
WHAT is this pull request doing?
Update React Router to 7.12.0 with stabilized future flags
This release uses React Router's newly stabilized future flags (
v8_splitRouteModules,v8_middleware) instead of their unstable counterpartsHOW to test your changes?
^ should succeed with no errors or warnings
Post-merge steps
Update the
h2 upgradechangelog to include upgrade instructionsChecklist