-
Notifications
You must be signed in to change notification settings - Fork 378
update SFAPI and CAAPI to 2025-10 #3352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
| '@shopify/hydrogen': major | ||
| '@shopify/hydrogen-react': major | ||
| '@shopify/cli-hydrogen': patch | ||
| 'skeleton': major |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should these actually be majors?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kdaviduik do you know if we need to bump the numbers of the calver manually for majors? Or is it done automatically by changeset?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the workflows are working properly, I thiiiink this should happen automatically. But the workflow that's supposed to do that hasn't been battle-tested and may have bugs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well in any case, merging this will update a Changesets PR where we'll be able to see the new versions before being released. We can fix them if needed.
kdaviduik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What errors are you seeing when trying to create a new app?
--
There are also a bunch of other changes needed within Hydrogen as part of this bump, like these sub-issues inside of this issue, but those should be done in separate (stacked!) PRs:
|
it’s not related to this, it’s because a newly created hydrogen app does not import from the monorepo’s hydrogen/hydrogen-react packages so it can’t create the route handler from the oxygen import etc I will try moving the test app created to inside the monorepo and then change the imports manually – but besides that, it’s all good! |
c28d882 to
c81e909
Compare
c81e909 to
2652707
Compare
|
/snapit |
graygilmore
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't able to 🎩 due to hitting stuff like:
npm i
npm error code ETARGET
npm error notarget No matching version found for @shopify/hydrogen@2025.10.0.
npm error notarget In most cases you or one of your dependencies are requesting
npm error notarget a package version that doesn't exist.
Maybe there are some tophatting tips?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(commenting here for 🧵)
Seems like it's just a simply find/replace and that there are no breaking changes in either of these APIs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
breaking changes coming in the stack!
|
it seems you just didn’t build the monorepo first! my bad for not including that in the tophatting instructions. will adjust on another note, this PR is the base for many others that will come from here so bear with us for a sec before reviewing! |
2652707 to
37ee345
Compare
37ee345 to
bce6ffc
Compare
bce6ffc to
cd65345
Compare
cd65345 to
bce6ffc
Compare
bce6ffc to
cd65345
Compare

WHY are these changes introduced?
This PR updates SFAPI and CAAPI to 2025-10, ahead of the next bump (2026-01)
WHAT is this pull request doing?
Updates constants and hardcoded versions everywhere, regenerates types for the client
HOW to test your changes?
npm run build --filter=skeletonat the root of the monorepo to build all packages that the skeleton needscd templates/skeleton && npm run devto spin up the skeleton appPost-merge steps
Checklist