Skip to content

ci: normalise dependency cache and node versions#3496

Merged
fredericoo merged 1 commit intomainfrom
fb-ci-normalise-cache-and-node
Feb 26, 2026
Merged

ci: normalise dependency cache and node versions#3496
fredericoo merged 1 commit intomainfrom
fb-ci-normalise-cache-and-node

Conversation

@fredericoo
Copy link
Contributor

WHY are these changes introduced?

  • .github/workflows/test-calver.yml was still pinned to Node 18, which no longer matches the repo's supported runtime ("node": "^22 || ^24").
  • pnpm cache setup in CI should consistently use the lockfile path for deterministic cache keys.

WHAT is this pull request doing?

  • Updates .github/workflows/test-calver.yml to use node-version: '22'.
  • Adds cache-dependency-path: 'pnpm-lock.yaml' to both .github/workflows/test-calver.yml and .github/workflows/test-upgrade-flow.yml.

HOW to test your changes?

  1. Run the targeted CLI unit test:
    • pnpm --filter @shopify/cli-hydrogen test -- template-pack.test.ts
  2. Confirm workflow changes in:
    • .github/workflows/test-calver.yml
    • .github/workflows/test-upgrade-flow.yml

Post-merge steps

None.

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@fredericoo fredericoo requested a review from a team as a code owner February 24, 2026 12:02
@shopify
Copy link
Contributor

shopify bot commented Feb 24, 2026

Oxygen deployed a preview of your fb-ci-normalise-cache-and-node branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment February 24, 202612:03 PM

Learn more about Hydrogen's GitHub integration.

@fredericoo fredericoo merged commit 949b471 into main Feb 26, 2026
21 of 22 checks passed
@fredericoo fredericoo deleted the fb-ci-normalise-cache-and-node branch February 26, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants