Skip to content

fix: formatting with prettier not working in non skeleton repos#3512

Merged
fredericoo merged 2 commits intomainfrom
fb-fix-prettier-root
Feb 26, 2026
Merged

fix: formatting with prettier not working in non skeleton repos#3512
fredericoo merged 2 commits intomainfrom
fb-fix-prettier-root

Conversation

@fredericoo
Copy link
Contributor

@fredericoo fredericoo commented Feb 26, 2026

WHY are these changes introduced?

Since we moved to pnpm prettier has been silently failing in code changes that are not the skeleton: because npm used to hoist the @shopify/prettier-config package from skeleton to the root of the monorepo, we were able to run it in other places.

Oh and we were not checking or formatting the skeleton template!

WHAT is this pull request doing?

  • adding @shopify/prettier-config at the root package.json
  • standardised version with catalog:
  • added ./templates to formating and checks

HOW to test your changes?

  • change the formatting a file outside skeleton (like a test)
  • format it
  • check output of prettier if you are on vscode and use the extension to ensure it loaded it all good

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@fredericoo fredericoo requested a review from a team as a code owner February 26, 2026 12:10
@shopify
Copy link
Contributor

shopify bot commented Feb 26, 2026

Oxygen deployed a preview of your fb-fix-prettier-root branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment February 26, 202612:27 PM

Learn more about Hydrogen's GitHub integration.

@@ -19,8 +19,8 @@
"encrypt": "ejson encrypt secrets.ejson",
"lint": "eslint --no-error-on-unmatched-pattern ./packages",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might want to add templates here as well, but i opted not to touch linting right now

Copy link
Collaborator

@andguy95 andguy95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💅

Copy link
Contributor Author

fredericoo commented Feb 26, 2026

Merge activity

  • Feb 26, 5:31 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Feb 26, 5:31 PM UTC: @fredericoo merged this pull request with Graphite.

@fredericoo fredericoo merged commit 10ce0fb into main Feb 26, 2026
15 checks passed
@fredericoo fredericoo deleted the fb-fix-prettier-root branch February 26, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants