fix: formatting with prettier not working in non skeleton repos#3512
Merged
fredericoo merged 2 commits intomainfrom Feb 26, 2026
Merged
fix: formatting with prettier not working in non skeleton repos#3512fredericoo merged 2 commits intomainfrom
fredericoo merged 2 commits intomainfrom
Conversation
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
fredericoo
commented
Feb 26, 2026
| @@ -19,8 +19,8 @@ | |||
| "encrypt": "ejson encrypt secrets.ejson", | |||
| "lint": "eslint --no-error-on-unmatched-pattern ./packages", | |||
Contributor
Author
There was a problem hiding this comment.
we might want to add templates here as well, but i opted not to touch linting right now
kdaviduik
approved these changes
Feb 26, 2026
Contributor
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Since we moved to
pnpmprettier has been silently failing in code changes that are not the skeleton: becausenpmused to hoist the@shopify/prettier-configpackage from skeleton to the root of the monorepo, we were able to run it in other places.Oh and we were not checking or formatting the skeleton template!
WHAT is this pull request doing?
@shopify/prettier-configat the root package.jsoncatalog:./templatesto formating and checksHOW to test your changes?
Checklist