Draft
Conversation
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PROBLEM
Related to https://github.com/shop/issues-learn/issues/1460
Sibling pr with top hat changes: https://github.com/shop/world/pull/547474
We have released generate-docs v1 and are now migrating references using the platform.
The time has come for hydrogen. Welcome, you lucky ducky 🦆
SOLUTION
generate_docs_data_v2.jsonand send a copy to the shopify-dev repo@publicDocstag to all top level types (and possibly update js doc comments if descriptions were missing)TOP HATTING
All top hatting will occur in the shopify-dev pr affiliated with the four migrated hydrogen versions