fix: validate that contexts exists before trying to build client #993
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
If the first file in environment variable
KUBECONFIGis "empty" with simply the following structurekranewill crash with the following error when trying to accesscontextsin gemkubeclientbecausecontextsis set tonullin the empty config.How is this accomplished?
By adding validation when creating
@kubeclient_configsto simply skip files in$KUBECONFIGthat havenullcontexts. This does parse the file twice tough (once inkranefor validation then inkubeclient).Is this the right approach?
What could go wrong?
Nothing really, file with
nullcontexts will be ignored when building the kube client.