Consistent logging

[bquorning]

Consistently log worker nr (where relevant) first, then generation, then pid. Use lowercase letters in most such messages.

Fixes #153

[bquorning]

I pushed one more commit, adding the methods Worker#to_log and Service#to_log. I thought about using the method name #to_s which would make the interpolation easier – but at the same time, the output might be confusing in other use cases (e.g. when debugging).

I didn't yet squash the changes, so that it's easier to see the difference between the "inline" logging and the logging with #to_log. Of course the two commits should be squashed before merging.

The to_log method can be implemented in a few different ways (nested ifs, interpolating "#{" pid=#{pid}" if pid}", etc.), and I am not 100% happy with any of them. Please let me know if you have a cleaner solution.

[bquorning]

Sorry about the force-push yesterday, but I had found four more locations to call to_log: https://github.com/Shopify/pitchfork/compare/7fde3c207694f5304cf7498246825bd5fe595cad..e787f9ede55e3d8d908fa389eb25f0d05af1de2e

[bquorning]

Is there anything I can do to help this PR move forward?

[byroot]

Is there anything I can do to help this PR move forward?

Nah sorry, I'm away from work and so is Étienne, so we can't merge.

@peterzhu2118 I think you've been looking at Pitchfork lately? This PR looks good to me, it would be worth merging.

[peterzhu2118]

@bquorning Thanks for the PR, I unblocked the tests and found that there's failures. Can you fix them?

[bquorning]

Hmm, it seems I cannot run those tests locally:

$ bundle exec megatest test/integration/test_reforking.rb
No tests to run

but I’ll go though the CI output and fix the tests as best I can. And then rely on CI to see if I catch all failures 😅

[bquorning]

Hmm, it seems I cannot run those tests locally:

🤦🏼 because I’m testing on a Mac, where Pitchfork::REFORKING_AVAILABLE is false. I am testing it in Docker now.

[bquorning]

There you go, tests are green now 🍏

[peterzhu2118]

Thank you!