Merge pull request rails#54489 from Edouard-chin/ec-readable-error

Fix unreadable output when running `rails test`:

Author: byroot

railties/lib/rails/commands/test/test_command.rb

@@ -31,8 +31,6 @@ def perform(*args)
         Rails::TestUnit::Runner.parse_options(args)
         run_prepare_task if self.args.none?(EXACT_TEST_ARGUMENT_PATTERN)
         Rails::TestUnit::Runner.run(args)
-      rescue Rails::TestUnit::InvalidTestError => error
-        raise ArgumentError, error.message
       end
 
       # Define Thor tasks to avoid going through Rake and booting twice when using bin/rails test:*

railties/lib/rails/test_unit/runner.rb

@@ -9,9 +9,16 @@
 
 module Rails
   module TestUnit
-    class InvalidTestError < StandardError
+    class InvalidTestError < ArgumentError
       def initialize(path, suggestion)
-        super("Could not load test file: #{path}. #{suggestion}")
+        super(<<~MESSAGE.rstrip)
+          Could not load test file: #{path}.
+          #{suggestion}
+        MESSAGE
+      end
+
+      def backtrace(*args)
+        []
       end
     end
 
@@ -65,7 +72,7 @@ def load_tests(argv)
               if corrections.empty?
                 raise exception
               end
-              raise InvalidTestError.new(path, DidYouMean::Formatter.message_for(corrections))
+              raise(InvalidTestError.new(path, DidYouMean::Formatter.message_for(corrections)), cause: nil)
             else
               raise
             end

railties/test/application/test_runner_test.rb

@@ -969,8 +969,13 @@ def test_did_you_mean_when_specified_file_name_is_close
       create_test_file :models, "account"
       output = run_test_command("test/models/accnt.rb")
 
-      assert_match(%r{Could not load test file.+test/models/accnt\.rb}, output)
-      assert_match(%r{Did you mean?.+test/models/account_test\.rb}, output)
+      expected = <<~MSG
+        bin/rails: Could not load test file: test/models/accnt.rb. (Rails::TestUnit::InvalidTestError)
+
+        Did you mean?  test/models/account_test.rb
+      MSG
+
+      assert_equal(expected, output)
       assert_not_predicate $?, :success?
     end
 

railties/test/generators/plugin_test_runner_test.rb

@@ -93,7 +93,7 @@ def test_fail_fast
 
   def test_raise_error_when_specified_file_does_not_exist
     error = capture(:stderr) { run_test_command("test/not_exists.rb") }
-    assert_match(%r{cannot load such file.+test/not_exists\.rb}, error)
+    assert_match(%r{Could not load test file.+test/not_exists\.rb}, error)
   end
 
   def test_executed_only_once