Merge pull request rails#44555 from koic/enable_style_map_to_hash_cop

Enable `Style/MapToHash` cop

Author: rafaelfranca

.rubocop.yml

@@ -159,6 +159,9 @@ Style/FrozenStringLiteralComment:
     - 'actionmailbox/db/migrate/**/*.rb'
     - 'actiontext/db/migrate/**/*.rb'
 
+Style/MapToHash:
+  Enabled: true
+
 Style/RedundantFreeze:
   Enabled: true
 

actiontext/lib/action_text/attachment.rb

@@ -91,7 +91,7 @@ def inspect
 
     private
       def node_attributes
-        @node_attributes ||= ATTRIBUTES.map { |name| [ name.underscore, node[name] ] }.to_h.compact
+        @node_attributes ||= ATTRIBUTES.to_h { |name| [ name.underscore, node[name] ] }.compact
       end
 
       def attachable_attributes

actiontext/lib/action_text/trix_attachment.rb

@@ -39,10 +39,10 @@ def transform_attribute_keys(attributes)
         end
 
         def typecast_attribute_values(attributes)
-          attributes.map do |key, value|
+          attributes.to_h do |key, value|
             typecast = ATTRIBUTE_TYPES[key] || ATTRIBUTE_TYPES[:default]
             [key, typecast.call(value)]
-          end.to_h
+          end
         end
     end
 

actionview/lib/action_view/ripper_ast_parser.rb

@@ -86,11 +86,11 @@ def to_hash
         end
 
         def hash_from_body(body)
-          body.map do |hash_node|
+          body.to_h do |hash_node|
             return nil if hash_node.type != :assoc_new
 
             [hash_node[0], hash_node[1]]
-          end.to_h
+          end
         end
 
         def symbol?
@@ -189,9 +189,9 @@ def parse_render_nodes(code)
         parser = RenderCallExtractor.new(code)
         parser.parse
 
-        parser.render_calls.group_by(&:first).collect do |method, nodes|
+        parser.render_calls.group_by(&:first).to_h do |method, nodes|
           [ method.to_sym, nodes.collect { |v| v[1] } ]
-        end.to_h
+        end
       end
     end
   end

activerecord/lib/active_record/connection_adapters/mysql/schema_statements.rb

@@ -57,9 +57,9 @@ def indexes(table_name)
               orders = options.delete(:orders)
               lengths = options.delete(:lengths)
 
-              columns = index[-1].map { |name|
+              columns = index[-1].to_h { |name|
                 [ name.to_sym, expressions[name] || +quote_column_name(name) ]
-              }.to_h
+              }
 
               index[-1] = add_options_for_index_columns(
                 columns, order: orders, length: lengths

activerecord/lib/active_record/encryption/encryptable_record.rb

@@ -188,12 +188,12 @@ def build_encrypt_attribute_assignments
         end
 
         def build_decrypt_attribute_assignments
-          Array(self.class.encrypted_attributes).collect do |attribute_name|
+          Array(self.class.encrypted_attributes).to_h do |attribute_name|
             type = type_for_attribute(attribute_name)
             encrypted_value = ciphertext_for(attribute_name)
             new_value = type.deserialize(encrypted_value)
             [attribute_name, new_value]
-          end.to_h
+          end
         end
 
         def cant_modify_encrypted_attributes_when_frozen

activestorage/test/service/mirror_service_test.rb

@@ -3,11 +3,11 @@
 require "service/shared_service_tests"
 
 class ActiveStorage::Service::MirrorServiceTest < ActiveSupport::TestCase
-  mirror_config = (1..3).map do |i|
+  mirror_config = (1..3).to_h do |i|
     [ "mirror_#{i}",
       service: "Disk",
       root: Dir.mktmpdir("active_storage_tests_mirror_#{i}") ]
-  end.to_h
+  end
 
   config = mirror_config.merge \
     mirror:  { service: "Mirror", primary: "primary", mirrors: mirror_config.keys },