Merge pull request rails#55106 from Edouard-chin/ec-dom-testing

byroot · web-flow · commit 332dc0db9a80 · 2025-05-24T09:37:09.000+02:00
Fix broken test when using rails-dom-testing 2.3:
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -469,7 +469,7 @@ GEM
       rack (>= 1.3)
     rackup (2.2.1)
       rack (>= 3)
-    rails-dom-testing (2.2.0)
+    rails-dom-testing (2.3.0)
       activesupport (>= 5.0.0)
       minitest
       nokogiri (>= 1.6)
diff --git a/actionpack/test/controller/caching_test.rb b/actionpack/test/controller/caching_test.rb
@@ -414,7 +414,7 @@ def test_preserves_order_when_reading_from_cache_plus_rendering
 
     get :index_ordered
     assert_equal 3, @controller.partial_rendered_times
-    assert_select ":root", "david, 1\n  david, 2\n  david, 3"
+    assert_select ":root", html: "<body><p>david, 1\n  david, 2\n  david, 3\n\n</p></body>"
   end
 
   def test_explicit_render_call_with_options
