fix(🤖): fix android snapshot view with SVG content #3612
Merged
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now supports SVGs from react-native-svg
Contributor
Author
|
Solves #2555 |
Contributor
Author
|
I have signed the CLA! |
wcandillon
reviewed
Dec 17, 2025
packages/skia/android/src/main/java/com/shopify/reactnative/skia/ViewScreenshotService.java
Outdated
Show resolved
Hide resolved
Contributor
|
Thank you so much for doing this, left a minor comment. |
Improved logging
Contributor
Author
|
@wcandillon Fixed comments in review |
Contributor
|
Thanks a lot, I'll add a test for it and we will ship it |
wcandillon
changed the title
Contributor
Author
|
@wcandillon are these changes available in the latest version on npm yet? |
Contributor
|
they are :)
…On Tue, Dec 23, 2025 at 2:35 PM Srikanth ***@***.***> wrote:
*XChikuX* left a comment (Shopify/react-native-skia#3612)
<#3612 (comment)>
@wcandillon <https://github.com/wcandillon> are these changes available
in the latest version on npm yet?
—
Reply to this email directly, view it on GitHub
<#3612 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACKXVRJMF76QS3BLL52THL4DFAJRAVCNFSM6AAAAACPGC4OROVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMOBWGY2TKNZZGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2555
Now supports SVGs from react-native-svg