Skip to content

fix(🤖): fix android snapshot view with SVG content #3612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wcandillon merged 5 commits into from
Dec 18, 2025
+11 −1
Merged

fix(🤖): fix android snapshot view with SVG content #3612

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6a7e23a
Update ViewScreenshotService.java
XChikuX Dec 16, 2025
ff4b55b
Fix indentation
XChikuX Dec 17, 2025
f1c66ca
Merge branch 'main' into patch-1
wcandillon Dec 17, 2025
dc71fef
Merge branch 'main' into patch-1
wcandillon Dec 17, 2025
590bf92
Merge branch 'main' into patch-1
wcandillon Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion packages/skia/android/src/main/java/com/shopify/reactnative/skia/ViewScreenshotService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,16 @@ private static Paint createPaint() {
return paint;
}

private static boolean isSvgView(View view) {
try {
String className = view.getClass().getName();
return className != null && className.startsWith("com.horcrux.svg");
} catch (Throwable t) {
Log.e("ViewScreenshotService", "Error checking if view is SVG", t);
return false;
}
}

private static void renderViewToCanvas(Canvas canvas, View view, Paint paint, float parentOpacity) {
float combinedOpacity = parentOpacity * view.getAlpha();
canvas.save();
Expand All @@ -83,7 +93,7 @@ private static void renderViewToCanvas(Canvas canvas, View view, Paint paint, fl
canvas.clipRect(clipLeft, clipTop, clipRight, clipBottom);
}

if (view instanceof ViewGroup) {
if (view instanceof ViewGroup && !isSvgView(view)) {
ViewGroup group = (ViewGroup) view;
drawBackgroundIfPresent(canvas, view, combinedOpacity);
drawChildren(canvas, group, paint, combinedOpacity);
Expand Down