Skip to content

chore(🪨): Fix Skia Graphite Build #3162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wcandillon merged 4 commits into from
May 26, 2025
Merged

chore(🪨): Fix Skia Graphite Build #3162

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
55aab48
chore(🪨): Fix Skia Graphite Builder
wcandillon May 25, 2025
c64d4bb
⬆️
wcandillon May 25, 2025
285aec8
Update build-skia-graphite.yml
wcandillon May 26, 2025
db45a82
Update build-skia-graphite.yml
wcandillon May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion .github/workflows/build-skia-graphite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,10 @@ jobs:
id: setup-ndk
uses: nttld/setup-ndk@afb4c9964b521afb97c864b7d40b11e6911bd410 # v1.5.0
with:
ndk-version: r22b
ndk-version: r26d

- name: Set ANDROID_NDK
run: echo "ANDROID_NDK=$ANDROID_HOME/ndk-bundle" >> $GITHUB_ENV

- name: Setup Ninja
uses: seanmiddleditch/gha-setup-ninja@master
Expand All @@ -24,6 +27,20 @@ jobs:
download_skia: 'false'
github_token: ${{ secrets.GITHUB_TOKEN }}

- name: Apply Dawn patch
run: |
DAWN_GNI_FILE="./externals/skia/build_overrides/dawn.gni"
if [ -f "$DAWN_GNI_FILE" ]; then
echo "Applying patch to dawn.gni..."
# Remove the specified lines from the end of the file
sed -i.bak '/# PartitionAlloc is an optional dependency:/,$d' "$DAWN_GNI_FILE"
echo "Patch applied successfully."
echo "Modified dawn.gni content:"
cat "$DAWN_GNI_FILE"
else
echo "Warning: dawn.gni file not found at $DAWN_GNI_FILE"
fi

- name: Build Skia with Graphite
working-directory: ./packages/skia
env:
Expand Down
Loading