Skip to content

fix(🤖): use generic type parameter in legacy arch #3580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wcandillon merged 2 commits into from
Nov 28, 2025
Merged

fix(🤖): use generic type parameter in legacy arch #3580

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0db703f
fix(android): use generic type parameter in legacy arch
wcandillon Nov 28, 2025
68f99ea
Merge branch 'main' into legacy
wcandillon Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ...droid/src/paper/java/com/facebook/react/viewmanagers/SkiaPictureViewManagerInterface.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,9 @@
import android.view.View;
import androidx.annotation.Nullable;

import com.shopify.reactnative.skia.SkiaPictureView;

public interface SkiaPictureViewManagerInterface<T extends View> {
void setDebug(T view, boolean value);
void setOpaque(T view, boolean value);
void setColorSpace(SkiaPictureView view, @Nullable String value);
void setColorSpace(T view, @Nullable String value);
void setAndroidWarmup(T view, boolean value);
}
Loading