Fix: avoid dangling pointer when reading runtime shader child name #3614
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent a dangling pointer by keeping the UTF‑8 string returned from JSI alive before calling c_str().
Root cause:
Code called arguments[1].asString(runtime).utf8(runtime).c_str() on a temporary; the temporary is destroyed at the end of the full-expression, producing a dangling pointer and triggering clang’s -Wdangling-assignment-gsl (failing Android native builds).
Change:
Store the UTF‑8 value in a local std::string and use childName = childNameStr.c_str() so the backing storage remains valid.
Files changed:
Testing / Verification:
Reviewer checklist: