return early if falling back to setTimeout for MessageChannel#528
Merged
brianshen1990 merged 1 commit intomainfrom Feb 5, 2025
Merged
Conversation
Contributor
Author
|
/snapit |
1 similar comment
Contributor
Author
|
/snapit |
brianshen1990
force-pushed
the
return-early-if-falling-back-to-`setTimeout`-for-MessageChannel
branch
from
31c583c to
900b84f
Compare
Contributor
Author
|
/snapit |
Contributor
|
🫰✨ Thanks @brianshen1990! Your snapshot has been published to npm. Test the snapshot by updating your "@remote-dom/core": "0.0.0-snapshot-20250203183857" |
brianshen1990
force-pushed
the
return-early-if-falling-back-to-`setTimeout`-for-MessageChannel
branch
from
900b84f to
5fa56c6
Compare
brianshen1990
force-pushed
the
return-early-if-falling-back-to-`setTimeout`-for-MessageChannel
branch
from
5fa56c6 to
df294ab
Compare
robin-drexler
approved these changes
Feb 4, 2025
oluwatimio
approved these changes
Feb 4, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, we've corrected an issue where the fallback to
setTimeoutin theBatchingRemoteConnectiondid not properly halt further execution, attempting to use the constructor even whenMessageChannelwas not available.This error particularly impacted tests run in a
jsdomenvironment. Now, we ensure an early return ifMessageChannelis unavailable to prevent this issue