Add comprehensive tests for selector parsing/matching and implement :not() #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
JoviDeCroock
approved these changes
Aug 29, 2025
lemonmade
approved these changes
Aug 29, 2025
Member
lemonmade
left a comment
lemonmade
left a comment
There was a problem hiding this comment.
Please add a patch changeset, then this looks good to go 👍
JoviDeCroock
force-pushed
the
cx-add-selector-tests-implement-not
branch
from
0290d56 to
0be84e0
Compare
- Added comprehensive test suite for selector parsing and matching (27 tests) - Implemented missing :not() pseudo-class selector functionality - Fixed class matching bug (now properly handles multiple classes) - Added universal selector (*) support - Fixed sibling combinators to skip non-element nodes - Fixed descendant/sibling matching logic for proper tree traversal - All selector tests pass with full type safety 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
JoviDeCroock
force-pushed
the
cx-add-selector-tests-implement-not
branch
from
0be84e0 to
d176f24
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a comprehensive test suite for selector parsing/matching and implements the missing :not() pseudo-class. While adding tests I uncovered and fixed several selector matcher bugs so selectors now behave much closer to CSS semantics.
What I changed
Tests
Implementation
Why this change
The repository previously had no tests for the selector parser/matcher, and the :not() selector was unimplemented. Adding tests found edge cases and bugs; this PR fixes them and ensures selectors match according to expected behavior.
Files of interest
Testing
Notes for reviewers
Commit
Co-authored-by: Claude [email protected]