Support multiple arguments in event listeners #598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor10k
changed the title
igor10k
force-pushed
the
i10k/support_multiple_args_in_event_listeners
branch
from
5fb97f2 to
75453e5
Compare
Contributor
Author
|
/snapit |
Contributor
|
🫰✨ Thanks @igor10k! Your snapshot has been published to npm. Test the snapshot by updating your "@remote-dom/core": "0.0.0-snapshot-20251006145527" |
lemonmade
approved these changes
Oct 6, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to restrict event listeners to only accepting a single argument when custom dispatchers are used.
Besides,
dispatchonRemoteEventRecordis already defined as being able to accept multiple arguments. All but the first one were thrown out though.