Fix syntax highlighting for line-ending forward slashes #3902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reese
changed the title
Author
|
I have signed the CLA! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #1786
This fixes an issue with syntax highlighting where slashes at the end of lines, such as for division across lines, strings with slashes at the end of lines, etc. were being read as regex contents. This would cause many lines of the source to be rendered in the same color, essentially removing any practical syntax highlighting. This would continue until another backslash was seen.
Implementation
This change makes two changes to the regex grammar. The first (the addition of
(?!\\s*$)) is a negative lookahead to reject/when followed only by whitespace until end of line. The second change removed the| $alternative that incorrectly allowed matching at end of line without a closing/.Automated Tests
See the added automated tests.
Manual Tests
I opened up a VSCode window with these changes.
Before ❌
After ✅