Add --json to diff, for use from scripts / tooling
#110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
necaris
force-pushed
the
feat/change-count
branch
from
8f6e03d to
86bb7bd
Compare
For some tooling (e.g. editors, prompts) it's helpful to know what modifications Shadowenv has made, in a short summary. This PR adds a `changes` subcommand that does just that: prints out a summary of the form `+added -removed ^updated`.
necaris
force-pushed
the
feat/change-count
branch
from
86bb7bd to
98efbc8
Compare
|
This seems like a fairly niche use case with incredibly specific output. I'm not sure that it warrants an entire subcommand. It does seem like there's a use case to serve here though. It's quite similar in concept to |
necaris
changed the title
changes subcommand--json to diff, for use from scripts / tooling
|
Thanks for taking on the feedback. I think this is going to be a nice feature. I'll be happy to re-review once you mark it ready, or answer any questions you may have in the meantime. |
joshheinrichs-shopify
force-pushed
the
main
branch
from
0cc46ea to
3c6b11d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some tooling (e.g. editors, prompts) it's helpful to know what
modifications Shadowenv has made, in a short summary. This PR adds a
changessubcommand that does just that: prints out a summary ofthe form
+added -removed ^updated.Example of this working with a Starship prompt:
