Allow Config File Inheritance#1393
Merged
casperisfine merged 5 commits intoShopify:mainfrom Apr 23, 2025
Merged
Conversation
70b041b to
7c2340e
Compare
casperisfine
approved these changes
Apr 23, 2025
Comment on lines
+144
to
+145
| inherits_from_path = path.dirname.join(config_obj.delete(SHIPIT_CONFIG_INHERIT_FROM_KEY)) | ||
| if inherits_from_path.exist? |
Contributor
There was a problem hiding this comment.
Open question: does a non existing path should noop or result in an error?
The problem is kinda always the same though, we don't have a good way of reporting shipit.yml errors, so perhaps nooping is the reasonable thing to do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1390
Allow setting an
inherit_fromkey in 'shipit.yml' config files.As of now this key expects a string. It is allowed to be chained:
Loading 'shipit_2.yml' results in:
Merge (deep) precedence = child overwrites parent (config file specified in
inherit_fromkey).