Update rubocop to support ruby 3.2 #1394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bostonou
approved these changes
Apr 17, 2025
bostonou
left a comment
bostonou
left a comment
There was a problem hiding this comment.
Approved, with another top-hat cycle expected
Contributor
Author
|
A final top-hat has been completed with smoke testing. Everything is behaving as expected. |
kartiki975
force-pushed
the
update-rubocop-to-support-ruby-3.2
branch
from
3c4a9fe to
d187b84
Compare
Remove rubocop-shopify gem Update .rubocop.yml Rubocop: auto-correct basic things Suppress warnings that are time-consuming to fix Add minor tweaks Suppress rubocop warnings for redeploy_state and deploy_state Minor rubocop tweaks Update file_system_test.rb Update stack.rb Update command.rb Update dev.rake
kartiki975
force-pushed
the
update-rubocop-to-support-ruby-3.2
branch
from
d187b84 to
8222b23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the
.rubocop.ymlconfiguration, upgrades therubocopgem in theGemfile, and applies various code improvements across multiple controllers in theShipitAPI. The changes focus on improving code readability, modernizing syntax, and disabling select RuboCop rules. Some rules were disabled to find the fastest way to do the Rails 8.0 upgrade.RuboCop Configuration and Gem Updates:
inherit_gemdirective forrubocop-shopifyand added exclusions forLayout/LineLengthin.rubocop.yml.Metrics/ClassLength,Style/Documentation,Metrics/AbcSize) in.rubocop.yml.rubocopgem from version1.18.3to~> 1.48.0in theGemfile.Syntax Modernization:
render_resourcesandtrigger_deploy. [1] [2]commits.newer_than(stack.last_deployed_commit)is now inline.Code Readability Improvements:
%i[index show]→%i[index show]). [1] [2]has_basic_credentials?tobasic_credentials?.Controller Enhancements:
StacksControllerto streamline repository filtering and parameter handling. [1] [2]MergeRequestsControllerto handle edge cases more concisely, including merged pull requests and cancellations.Note for reviewers
I will squash all the commits down before merging the PR.