Preserve ENV vars on Rollback #1399
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserve Environment Variables During Rollbacks
Changes
This PR ensures that environment variables are properly preserved when performing rollbacks in Shipit. The changes include:
trigger_revertmethod to accept and pass through environment variablesTechnical Details
envparameter totrigger_revertmethodTesting
Added comprehensive test coverage in
deploys_test.rbto verify that:Impact
This change ensures that rollbacks maintain the same environment configuration as the original deploy, preventing potential issues that could arise from missing or incorrect environment variables during rollback operations.